Fix case where preloaded paths have @ in them #619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #619 +/- ##
=======================================
Coverage 78.00% 78.00%
=======================================
Files 9 9
Lines 3769 3769
=======================================
Hits 2940 2940
Misses 829 829 🚀 New features to boost your workflow:
|
mcbarton
force-pushed
the
Fix-@-in-absolute-path-for-sysroot_path
branch
from
ba40e25 to
2c6a587
Compare
|
@anutosh491 @vgvassilev @Vipul-Cariappa @aaronj0 can one of you approve this PR, so I can take it in? I have tested the solution in this PR, and it is the same one xeus-cpp is using in a PR in that repo (here compiler-research/xeus-cpp#333) that has already been approved. That way I can take both in together, so we have consistency between how repos about how to solve this problem. |
mcbarton
force-pushed
the
Fix-@-in-absolute-path-for-sysroot_path
branch
3 times, most recently
from
6e5c26b to
bf9c05c
Compare
mcbarton
changed the title
aaronj0
approved these changes
Jun 16, 2025
There was a problem hiding this comment.
LGTM! Please follow up with @anutosh491 and @vgvassilev on compiler-research/xeus-cpp#333 before merging this PR
mcbarton
force-pushed
the
Fix-@-in-absolute-path-for-sysroot_path
branch
from
bf9c05c to
ad4d614
Compare
vgvassilev
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist